Fix: npm prepare script on Windows (refs #166) #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous script worked on macOS and Linux, but I neglected to consider Windows. This wouldn't affect users thankfully, only developers, so the blast radius would have been small had it not been caught. Now that we're testing on Windows, future bugs like this should be caught. I'm out of ideas for doing this entirely inside npm scripts, so I broke down and did it in JS.
btmills
changed the title
They occasionally exhibit extremely slow filesystem performance.
nzakas
approved these changes
Dec 19, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#166 originally reported being unable to
npm installin the repository on Windows. This was due to the changes in #164, which worked fine on Linux and macOS but not Windows. This PR first adds macOS and Windows to the test matrix and then fixes the npm prepare script by moving the previous bash-only logic into JS.